search

linz / QGIS-AIMS-Plugin

QGIS Plugin for managing LINZ address information
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Screen not refreshing correctly when moving addresses #197

Open SPlanzer opened 7 years ago

SPlanzer commented 7 years ago

This is directly related to: https://github.com/linz/AIMS/issues/227 but has been opened here to give it visibility against the plugin

Intial comment below:

If you move multiple address points, it displays the 'before' and 'after' positions, 
but when you accept the  first record from the review queue, the remaining points 
appear to jump from the 'before' position to the 'after' position, 
despite not having been accepted."
SPlanzer commented 7 years ago

Understood, not fixed

This bug has existed since the "move tool" sprint 6 + months ago but has just been discovered.

The move tool code must be refactored to modify the coordinates against a clone rather than the AIMS address feature being moved.

This requires a small change to the move tool code but also will require some modification to the data_managers Address.clone() method ideally by @josephramsay . Currently the clone method clones the aims feature but must be modified to go deeper and also clone the recursive objects (e.g. address position object).

This bug only has a short term visual impact to the user (i.e. no data corruption or chance of corruption) and only when a certain work flow is follow, which seems to be rear. As I understand it we are reviewing all enhancements in a few weeks and I will leave to also be prioritised then.