linz / QGIS-AIMS-Plugin

QGIS Plugin for managing LINZ address information
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Unable to update the road centre line of an existing Proposed address. #230

Open SPlanzer opened 5 years ago

SPlanzer commented 5 years ago

originally opened as part of #229 and the below is copied over.

Issue 2 - Unable to update the road centre line of an existing Proposed address. Steps to reproduce the error message is as follows:

  1. Search for an existing proposed address.
  2. Click on the Update AIMS Feature button.
  3. Click on the button used to select a new road centre line.
  4. Select a different road centre line and submit.

image

This causes issues because if a road centre line needs to be changed, the address has be retired and then re-entered. The user has to attach the address to the correct centre line and make it proposed again.

SPlanzer commented 5 years ago

The UI had a check put in place to stop addresses being updated to proposed (see #213). Its need at the UI level is questionable.

Triage-ing this issue will begin with removing this check and performing this action against the API to confirm the API allows this action. If so, removing the UI check should be considered

SPlanzer commented 5 years ago

I have built a test environment and confirmed the UI is blocking this action that the API will allow.

The below code can be safely removed from the UI to allow AIMS users to update proposed address properties.

https://github.com/linz/QGIS-AIMS-Plugin/blob/e1303f21924f5ddea87959e9efb1308c3ae4f4c9/AimsUI/AimsClient/Gui/UiUtility.py#L380-L383

This will not have any adverse effects as the API checks for addresses being changed from current to proposed, a situation that may lead to data corruption (see #229)

@MarksNgahi if you would like this improvement made to allow the updating of proposed address properties, please request this work via @TrentGulliver as he will have a better understanding as to how this piece of work would fit into the addressing programme.

This would involve:

Note #213 is related to this.