search

linz / bde-fdw-rds

Python AWS cdk to create rds with fdw for BDE analytica queries
MIT License
0 stars 0 forks source link

Refactor lambda bundling in bde-analytics FDW cdk #27

Open Jimlinz opened 1 year ago

Jimlinz commented 1 year ago

This CDK zips Python code and packages up as part of the lambda bundling process. This could be simplified slightly by removing the zip functionality, thus simplifying the code slightly.

Jimlinz commented 1 year ago

Should note that the following limit applies for lambda code:

50 MB (zipped, for direct upload) 250 MB (unzipped)

AWS seems to recommend deployment as zip or container https://docs.aws.amazon.com/lambda/latest/dg/gettingstarted-package.html#gettingstarted-package-layers

Although there would be less code to manage by removing zip, I am unsure if the added benefit is all that worthwhile, especially since zipping up our code allows for using layers (which would be useful to build on in the future)... Perhaps this is a case of premature optimisation...

Further discussion amongst the team needed. I would say this is low priority..