search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Startup #99 #100

Closed SPlanzer closed 4 years ago

SPlanzer commented 4 years ago

Resolves CI ImportError: cannot import name 'Config' error

SPlanzer commented 4 years ago

@strk the docker image is failing. to get this to work I am using FROM qgis/qgis:release-3_10

however against #96 you said

Addressing a QGIS branch rather than QGIS tag (makes builds less predictable)

I am getting this image from https://hub.docker.com/r/qgis/qgis/tags. Which image should I be using considering qgis/qgis:final-3_10_4_disco is failing (see #92)?

strk commented 4 years ago

I am getting this image from https://hub.docker.com/r/qgis/qgis/tags. Which image should I be using considering qgis/qgis:final-3_10_4_disco is failing (see #92)?

Could you try final-3_10_5 ?

SPlanzer commented 4 years ago

Could you try final-3_10_5 ?

Yip, updated to final-3_10_5, push and passed CI

SPlanzer commented 4 years ago

The fact that CI was green even without that file suggests it would be useful to have CI also run the make docker-up target (and then we'd want that target to fail if one of the containers do not stay on) - but can be postponed if you don't have time now

Next CI step is to integrate pyhton integration tests. This will indicate any issues with containers