Closed SPlanzer closed 4 years ago
This is as grep doesn't give an error in bash, but it does return a non-zero exit code:
will follow above advice and add || true
also found that
find . ! -name '*.git' ! -name '*.png' -type f
is not ignore git
and am now using
find . -type f -not -path "*\.git/*" -not -name "*\.png"
Bug Description
Using the formatting make commands for trailing whitespace I added yesterday it is clear they were not correctly tested.
https://github.com/linz/gazetteer/blob/ec7caa01bf19aa49521c1c93acf3355954819d8c/Makefile#L45-L51
What runs in bash is failing via make.
Steps to Reproduce
running the below make targets
make formatting-validate-trailing-whitespace
make formatting-clean-trailing-whitespace
they throw
make: *** [formatting-validate-trailing-whitespace] Error 1
This does not affect black targets
Desktop
Ubuntu 18
Screenshots
Add an Assignee, Epics, Estimate and any relevant Labels.