search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Document python3 requirement, fix linter on ubuntu 18.04 #128

Open strk opened 4 years ago

strk commented 4 years ago

NOTE: the linter did not like my commit message beacuse there was no reference to an issue (annoying!)

strk commented 4 years ago

I filed #129 to reference in the commit...

strk commented 4 years ago

So, linter is still not happy with ticket references in the BODY of the commit log, but rather insists in having it in the title:

1: T7 Title does not match regex (^.?#[0-9]+\b.?$): "chore: document python3 requirement, fix linter on ubuntu 18.04"

Can we change this policy to allow for references to be in the body ? I think titles should be for human consumption, ease of telling what's being changed...

billgeo commented 4 years ago

Can we change this policy to allow for references to be in the body ?

I'm okay with this. I find it annoying to have an issue reference too. Also, okay to remove that requirement altogether. But would be good to make it consistent with other Data Services / LI repos if possible?

SPlanzer commented 4 years ago

this also needs to be enabled in CI https://github.com/linz/gazetteer/blob/8d68f9c4d909409223032a82f0bfa6dd302144f9/.github/workflows/push.yml#L28-L30

strk commented 4 years ago

checks here passed, anyway, so what's holding this back ?