search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Target QGIS 3.12 #143

Closed strk closed 3 years ago

strk commented 4 years ago

Use the 3.12 version of QGIS docker image. This is mostly to see if we can remove the monkey patch of testrunner

SPlanzer commented 4 years ago

It would be great if we could remove the monkey patching of the test runner.

@strk, What are your thoughts of using 3.12 for automated tests when the software is going to be deployed against the LTR 3.10? I would expect 100% compatibility between the versions but I and expect others would be much more comfortable with using 3.10 if that is what the release will be against

billgeo commented 4 years ago

I think we'd be okay to do this for something like the Gazetteer. But should expect the odd bug to come in from the NZGB team because of this.

strk commented 4 years ago

On Wed, Jun 17, 2020 at 01:56:28PM -0700, Simon Planzer wrote:

It would be great if we could remove the monkey patching of the test runner.

Yes, that's my thought. Only I've been having troubles finding instructions to reproduce the bug which made us using the monkey-patch in the first place. Do you have a link to the corresponding ticket ?

It doesn't help that my make docker-qgis-start command does NOT always succeed in showing the qgis window (often I get decorations but no content of windows, and trying to debug that).

What are your thoughts of using 3.12 for automated tests when the software is going to be deployed against the LTR 3.10? I would expect 100% compatibility between the versions but I and expect others would be much more comfortable with using 3.10 if that is what the release will be against

For tests we'd ideally use BOTH 3.10 and 3.12

strk commented 3 years ago

Monkey patching removed. If it works, this is a good step toward testing multiple versions of things. @billgeo this includes testing PostgreSQL-12, for example