linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Tests create new #145

Closed SPlanzer closed 4 years ago

SPlanzer commented 4 years ago

Fixes: # address - https://github.com/linz/ds-group-epics/issues/133 The main purpose of this is to test adding a new place feature/name and editing its properties.

This also introduces an entire approach to testing the plugin features and managing test data

Happy to talk anyone through this in person

Change Description:

...

Notes for Testing:

Let CI run ...

Source Code Documentation Tasks:

User Documentation Tasks:

Testing Tasks:

Pull Request Management:

SPlanzer commented 4 years ago

FYI @strk as talked about - here is a draft PR

I need to review why tests are failing in CI and then I will seek review

SPlanzer commented 4 years ago

@billgeo @strk This is at the point that it is ready for review.

Apologies this is very large. I am happy to talk in our next meeting how to best manage review on this project

billgeo commented 4 years ago

Thanks @SPlanzer. I see all the CI is passing.

Maybe I can review the test coverage and @strk can review the approach/framework for running the tests?

Can you confirm what tests in https://confluence.linz.govt.nz/display/MNAI/NZGB+Gazetter+Plugin+Tests are delivered as part of this PR?

SPlanzer commented 4 years ago

FYI @billgeo

Can you confirm what tests in https://confluence.linz.govt.nz/display/MNAI/NZGB+Gazetter+Plugin+Tests are delivered as part of this PR?

This covers - Written "Test Plan #1: Create a new entry in the Gazetteer, populating all fields"

Coverage is intentionally not 100%