linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

geoalchemy2 src code #190

Closed SPlanzer closed 4 years ago

SPlanzer commented 4 years ago

Fixes: #

Change Description:

Notes for Testing:

As per #189 test are required to pass without sqlalchemy and geoalchemy2 in requirements.txt

Source Code Documentation Tasks:

User Documentation Tasks:

Testing Tasks:

Pull Request Management:

strk commented 4 years ago

I don't like the idea of importing external code into the git repository. Rather, inclusion should be done at release time (do we have a Makefile target to create a release?). Alternatively it could maybe be a git submodule ?

SPlanzer commented 4 years ago

agreed - I will have the github actions install these at release

SPlanzer commented 4 years ago

Closed by #195

strk commented 4 years ago

Closing as per last comment

strk commented 4 years ago

@SPlanzer I guess the branch can be deleted ? (doing some cleanups)