Spatial search wrapping around planet for searches at 180°

[CMKMS-LINZ]

Bug Description

Spatial searches when 180° longitude visible in map window don't work as intended

Steps to Reproduce

If: 1): the 'Limit Search to map area' box is ticked to conduct a spatial search, 2): the user searches without anything in the search box, 3): clicks search while 180° longitude is visible 4): results for everything from 180°E to -180°W eastward (ie, planet wrap around) will be received instead of the area of the map window

Similarly, if 1): the 'Limit Search to map area' box is ticked to conduct a spatial search, 2): the user searches for the name of a feature that would be parallel to the map area east or west 3): clicks search while 180° longitude is visible, zoomed in in the ocean 4): results for the feature will be populated

Searching a spatial window entirely over 180°, such as while zoomed in on the Chatham Islands, behaves as expected, though selecting a feature leads to #206

Desktop

• Environment: [e.g. Windows 10]
• Relevant Software Versions: [Gazetteer Plugin 2.0.0-UAT, QGIS 3.14.0]

Screenshots

[SPlanzer]

Hi @CMKMS-LINZ I am just trying to reproduce this issue whereby everything is returned from 180-180 even when using "Limit search to map area" but am failing to do so. Perhaps I am misinterpreting the steps so I have attached a GIF. This shows

• The 180 longitude (black dashed line) which I have navigated to.
• I then enable the "Limit search to map area"
• and hit "Search". This returns two features.
• I then zoom out and hit search again. This returns more results with the greater map extent. but not everything from 180-180

Is this as expected?

[CMKMS-LINZ]

The difference will be that you're in EPSG:4167 (NZGD 2000). Using 2193 (NZTM), 3793 (Chathams TM), (Raoul Island TM) 3031 (Antarctic polar stereographic), 5482 (Ross Sea Region Polar stereographic), 3857 (Psuedo Mercator) as projections we would commonly use all have the issue described.

4326 (WGS 84) behaviour is like the 4167 above.

[SPlanzer]

That makes sense.

Looking at the source code. The '_doSearch' function is explicit in that it only handles NZGD2000 https://github.com/linz/gazetteer/blob/b253e610375abdc880450d4e0d3d08d45de6a677/src/NZGBplugin/LINZ/gazetteer/gui/NameSearchWidget.py#L147-L148

Looking at the source code the plugin is designed to be used with NZGD2000 for example:

• One of the first variable encountered in the plugin sets the srid to NZGD https://github.com/linz/gazetteer/blob/b253e610375abdc880450d4e0d3d08d45de6a677/src/NZGBplugin/Layers.py#L110
• And database functions are hard coded to take geom as 4167 and return it as 4167 for example: https://github.com/linz/gazetteer/blob/ec7caa01bf19aa49521c1c93acf3355954819d8c/src/sql/gazetteer_functions.sql#L285-L291