search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Possible to create name entries with no name #211

Closed CMKMS-LINZ closed 3 years ago

CMKMS-LINZ commented 4 years ago

Bug Description

If two Create new feature dialogue boxes are open, pressing OK on the 1st one will submit the details of the 2nd newer one, bypassing the check that something is entered in the Name field, eg, creating a blank entry.

This is not possible in Production plugin version 1.8.2 as the Gazetteer tools (and all other QGIS buttons, fields, etc) are locked off while the Create new feature box is open.

Steps to Reproduce

  1. Select create new feature tool
  2. Click once to open the Create new feature box
  3. Click somewhere else on the map window, thereby opening a second one.
  4. Enter something in the name field in the 1st box
  5. Press OK
  6. A new name entry is created using the details from the 2nd box, where the name field is blank

Desktop

Screenshots

Incidentally, the name field in the blank entry has [ class=] in the name field (including the preceding space) when opened with edit.

image

SPlanzer commented 4 years ago

Bug triage for QGIS3 initial release

Porting has introduced the ability of the user to trigger this bug by making the new feature dialog non modal.

Next steps

make dlg noon-modal and release as part of 2.0.2