Cannot add any external geometry of any type to a name

CMKMS-LINZ commented 3 years ago

Bug Description

No external point, line, polygon layers can be added to a name with the add tool (ie UAT plan 3 step 54 onwards).

Steps to Reproduce

Open a name
Add a point layer, eg Survey Plan reference points
Highight some points, click Add Selected geometries to feature
Dialogue box asks to confirm, click OK
Nothing happens
Repeat with lines (nothing happens)
Repeat with polygons (nothing happens).

At step 4, the dialogue box is missing the word points/lines/polygons and failing to enumerate the geometry, which may provide some indication of what the problem is.

This has also been tested against layers created in EPSG 4167 to see if it had changed to only accept geometry in the same projection as the database, but nothing happens here either.

Desktop

Environment: [Windows 10]
Relevant Software Versions: [Gazetteer Plugin 2.0.1 UAT, QGIS 3.14.0]

Screenshots

production

UAT

SPlanzer commented 3 years ago

Bug triage for QGIS3 initial release

I have been unable to reproduce this. I wonder if this is related to particular datasets being imported.

As per the image below I created a data set of ten points and associated these to Opotiki. This also said "10 points".
I also imported ~2000 address points and associated ~545 to a feature successfully. I can confirm these were recorded in the databases gazetteer.feature_geometry table
I can confirm I had the same behaviour with lines and polygons

Next steps

Will need @CMKMS-LINZ to walk me through this

CMKMS-LINZ commented 3 years ago

I did some further tests and immediately found that the issue occurs for Multipolygons, Multilinestrings, Multipoints.

It recognises and enumerates point, linestring, and polygon layers.

I saved a multilinestring as a shapefile and then checked in QGIS 2.6.1 / Prod 1.8.2 plugin, and you can add it, but I don't know if perhaps it's just being read as a linestring.

SPlanzer commented 3 years ago

This was resolved when #218 was addressed.

This was therefore released as part of 2.0.2-UAT but was over looked to get tested. It looks like #212 will force another UAT release and we will have this undergo UAT then

linz / gazetteer