linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

Repair automated test: test_O_add_new_poly_and_move #235

Closed billgeo closed 3 years ago

billgeo commented 3 years ago

Task

======================================================================
FAIL: test_O_add_new_poly_and_move (test_edit_geom.TestNewFeature)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/.local/share/QGIS/QGIS3/profiles/default/python/plugins/NZGBplugin/tests/test_edit_geom.py", line 1109, in test_O_add_new_poly_and_move
    self.assertAlmostEqual(v4.x(), 174.5461, places=3)
AssertionError: 174.556599844937 != 174.5461 within 3 places

----------------------------------------------------------------------
Ran 52 tests in 137.431s

FAILED (failures=1)
Finished running test tests_directory.run_tests.run_test_modules (codes: IS_DEAD=1 IS_FAILED=0 IS_PASSED=1).
make: *** [docker-qgis-test] Error 1
Makefile:40: recipe for target 'docker-qgis-test' failed
Error: Process completed with exit code 2.

Definition of Done

CI is passing and test is repaired

Out of Scope

Discussion required

SPlanzer commented 3 years ago

What has changed? This can be an issue with screen resolution

billgeo commented 3 years ago

Sorry, I missed you comment @SPlanzer I just changed the changelog file. So didn't expect it to fail the CI.

billgeo commented 3 years ago

This was only failing on QGIS 3.12 test for some reason. Have removed QGis 3.12 from CI. Will open a ticket for this if and when we need to test on QGIS 3.12