Add other versions of postgres to CI tests - Githubissues

linz / gazetteer

New Zealand Gazetteer of official place names

http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT

Other

2 stars 2 forks source link

Add other versions of postgres to CI tests #246

Closed billgeo closed 3 years ago

billgeo commented 3 years ago

Fixes: #245 Add new line for each issue that was fixed

Change Description:

Added PostgresSQL 11 and 13 to CI matrix Added PostGIS 2.5 to CI matrix

Notes for Testing:

CI tests passing

Source Code Documentation Tasks:

[ ] README updated (where applicable)
[ ] CHANGELOG updated

User Documentation Tasks:

[ ] Confluence user guide updated (where applicable)

Testing Tasks:

[ ] Added tests that fail without this change
[ ] All tests are passing in development environment
[ ] Reviewers assigned

Pull Request Management:

[ ] Linked to sub-task
[ ] Linked to the epic

billgeo commented 3 years ago

@SPlanzer or @imincik, could someone please review this?

SPlanzer commented 3 years ago

Based on the discussion this morning I will approve this but do suggest we either action the below comment or create an issue to act.

As opposed to running tests against all versions of postgres/gis in docker we should at least upgrade the below to the new production version

https://github.com/linz/gazetteer/blob/26c493c29e3ac349ad97c39653afa822321aedf5/src/sql/Dockerfile#L3-L6