search

linz / gazetteer

New Zealand Gazetteer of official place names
http://www.linz.govt.nz/regulatory/place-names/find-name/new-zealand-gazetteer-official-geographic-names/new-zealand-gazetteer-search-place-names#zoom=0&lat=-41.14127&lon=172.5&layers=BTTT
Other
2 stars 2 forks source link

trim trailing whitespace from plugin python sources #80

Closed strk closed 4 years ago

strk commented 4 years ago

Respects editorconfig

strk commented 4 years ago

The EditorConfig action from marketplace is too expensive, BUILDS a docker to run that simple check, really not that ideal. Better get back to simple checking... (see https://github.com/linz/gazetteer/runs/536081065)

SPlanzer commented 4 years ago

Ive made a number of changes in branch 2to3 that I'm guessing will conflict. I will run these through black to tidy up white spaces.

If this wasn't too much work I think it would be easier to close this and I will clean the branch that I already have many changes to the same files.

strk commented 4 years ago

Big improvement here is the CI testing for blanks not to come back, if you enable that test in your branch and ensure is passes, I'm happy to close this. But note I did this because any file I'd touch would otherwise be changed to match editorconfig recommendations and this means my changes would be a mix of style and functional changes. The goal here was to keep those commits separated.

SPlanzer commented 4 years ago

Big improvement here is the CI testing for blanks not to come back, if you enable that test in your branch and ensure is passes, I'm happy to close this. But note I did this because any file I'd touch would otherwise be changed to match editorconfig recommendations and this means my changes would be a mix of style and functional changes. The goal here was to keep those commits separated.

This would have been best practice. Unfortunately I have made many functional code changes to the same files. I will added the CI into my branch and get this merged ASAP.

strk commented 4 years ago

@SPlanzer did you port the workflow in your PR yet ? Let me know if so, then we can close this one

SPlanzer commented 4 years ago

@SPlanzer did you port the workflow in your PR yet ? Let me know if so, then we can close this one

I have added it to .github/workflows/push.yml but commented it out as there needs to be a piece of work to solve formatting issues. This will be the next task.

Based on this I think we can close this

strk commented 4 years ago

Ok, closing, thanks