liodali / osm_flutter

OpenStreetMap plugin for flutter
https://pub.dev/packages/flutter_osm_plugin
MIT License
235 stars 97 forks source link

marker get smaller #560

Closed lvenier closed 1 month ago

lvenier commented 1 month ago

Hello,

I am encountering an issue in the usage of the plugin. I have a map where I have added a marker :

image

Im my app if I change the marker color and add a circle with the following functions : await controller.setMarkerIcon(geopoint, blackIcon); await controller.drawCircle(CircleOSM( key: "BlackPoint", centerPoint: geopoint, radius: 30.0, color: Colors.white.withOpacity(0.5), borderColor: Colors.white, strokeWidth: 0, ));

I have may Marker size being changed (looks like divided by 2) :

image

Anything I should do ? Many thanks for your help.

liodali commented 1 month ago

on which platform you faced the issue ?

lvenier commented 1 month ago

on which platform you faced the issue ?

no issue on android. not tested on apple. web only.

liodali commented 1 month ago
lvenier commented 1 month ago
  • is the issue happen when you draw the circle or when you set the marker icon ? if i change a markerIcon with no circle it is working. It looks it is adding the circle that create the image reduction.
  • another unrelated question are you happy with result from osrm because im working on adding other services like valhala or openroute ? I have to say osrm is not the greatest but it is enough for our usage.
liodali commented 1 month ago

thnx for your feedback i will make fix for the bug and for routing like i said im working on adding more routing api in our routing client

liodali commented 1 month ago

new version has being published 1.3.1

lvenier commented 1 month ago

Thanks for your fix.

I was not able to test as I get the following error when upgrading to 1.3.0 :

image

I have also the same issue in 1.3.1

liodali commented 1 month ago

iwill back home soon i will check it and do fix sorry for that

lvenier commented 1 month ago

iwill back home soon i will check it and do fix sorry for that

Do you need any additionnal info ? let me know if I can help.

liodali commented 1 month ago

technically no i need to fix migration to web package the issue that response from js not what we expect so i will setup https for localhost that i can test getcurrentposition correctly

liodali commented 1 month ago

new version has been published 1.3.2

lvenier commented 1 month ago

Thanks for the new version.

I have upgraded and tested and Im getting a new error :

image

it looks it is happening on

await controller.setMarkerIcon(geopoint,icon)
liodali commented 1 month ago

can you show me more of error trace ?

lvenier commented 1 month ago

localhost-1726648923033.log

I have added the log file from my browser. Hope it helps. If not let me know how I can help.

liodali commented 1 month ago

new version is already published 1.3.3

lvenier commented 1 month ago

new version is already published 1.3.3

I will test it today. Many thanks

lvenier commented 1 month ago

All good ! It is working and no more issues. Issue can be closed.