lion03 / thrust

Automatically exported from code.google.com/p/thrust
Apache License 2.0
0 stars 0 forks source link

user-invisible macros like THRUST_HOST_COMPILER need to begin with two underscores #263

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
These all live under thrust/detail/config

Original issue reported on code.google.com by jaredhoberock on 3 Nov 2010 at 6:51

GoogleCodeExporter commented 8 years ago
I disagree. From http://www.doc.ic.ac.uk/lab/cplus/c++.rules/chap5.html

The use of two underscores (`__') in identifiers is reserved for the compiler's 
internal use according to the ANSI-C standard. 

Original comment by seb.scha...@gmail.com on 4 Feb 2011 at 8:11

GoogleCodeExporter commented 8 years ago
Here's some more commentary:
http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-unde
rscore-in-a-c-identifier

Original comment by wnbell on 4 Feb 2011 at 8:22

GoogleCodeExporter commented 8 years ago
Let's go with the status quo for now and reevaluate this issue later

Original comment by wnbell on 6 Feb 2011 at 6:54

GoogleCodeExporter commented 8 years ago
Forwarded to https://github.com/thrust/thrust/issues/72

Original comment by jaredhoberock on 7 May 2012 at 9:27