lion0406 / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Errors in Float16ToFloat32.py #376

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run Float16ToFloat32.py through Python on Windows 7

What is the expected output? What do you see instead?
A compiling version of Float16ToFloat32.cpp

What version of the product are you using? On what operating system?
Trunk on Win7 Entreprise 64-bit

Please provide any additional information below.

The Float16ToFloat32.py script has a few minor bugs in it I think.

1) First of all the numeric values are printed with the wrong string format, in 
order to compile, the hexadecimal values must be prefixed by "0x". This is 
accomplished by using the alternate form of the hex formatter as stated here:

http://docs.python.org/library/stdtypes.html#string-formatting

So essentially "%08x" should be "%#08x"

2) There appears to be an extra '=' sign on line 74 of the script:

unsigned i32 = =g_mantissa...

Original issue reported on code.google.com by jasonrba...@gmail.com on 11 Oct 2012 at 3:26

GoogleCodeExporter commented 9 years ago
Fix is here: https://codereview.appspot.com/6651047/

Original comment by apatr...@chromium.org on 11 Oct 2012 at 6:06

GoogleCodeExporter commented 9 years ago
Fixed with r1320

Original comment by apatr...@chromium.org on 23 Oct 2012 at 8:38