lion0406 / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Shader validator must reject default precision qualifier with illegal type operand #410

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In http://www.khronos.org/bugzilla/show_bug.cgi?id=781 it was pointed out that 
the statement "precision highp vec4;" was accidentally included in a new 
conformance test. It was an accident that highp was used, but in addition, vec4 
is an illegal type in a default precision statement. The only valid types are 
int, float and the sampler types. The shader translator needs to be fixed to 
fail compilation in this case.

Original issue reported on code.google.com by kbr@chromium.org on 4 Feb 2013 at 10:35

GoogleCodeExporter commented 9 years ago
New conformance tests verifying this:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shader-wi
th-illegal-default-precision.frag.html
https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shader-wi
th-illegal-default-precision.vert.html

Original comment by kbr@chromium.org on 4 Feb 2013 at 11:27

GoogleCodeExporter commented 9 years ago
I'll have a look

Original comment by z...@google.com on 6 Feb 2013 at 7:29

GoogleCodeExporter commented 9 years ago
Already being addressed here: https://codereview.appspot.com/7302043/

Original comment by nicolas....@gmail.com on 6 Feb 2013 at 7:32

GoogleCodeExporter commented 9 years ago
Actually already fixed. I forgot to link to this bug in the code review.

Original comment by kbr@chromium.org on 6 Feb 2013 at 9:12

GoogleCodeExporter commented 9 years ago
Cool.

Original comment by z...@google.com on 6 Feb 2013 at 9:14