search

lionel- / redpen

1 stars 2 forks source link

Implement node_match() #1

Closed lionel- closed 6 years ago

lionel- commented 7 years ago

Depends on tidyverse/rlang#270

Syntax and semantics described here: https://github.com/lionel-/redpen/pull/1/files#diff-15de555e9934617c671137c0181abcaa

cc @hadley

garrettgman commented 7 years ago

Agreed. I think we are coming up with a useful mental model of code as much as a package. We should think about how to deliver both.

On Mon, Oct 16, 2017 at 9:50 AM, Hadley Wickham notifications@github.com wrote:

@hadley commented on this pull request.

In R/node-match.R https://github.com/lionel-/redpen/pull/1#discussion_r144851987:

@@ -0,0 +1,454 @@ +#' Match patterns to a call

FWIW I think teachers are going to have to internalise the tree model of code, at least to the level described in https://adv-r.hadley.nz/ expressions.html

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lionel-/redpen/pull/1#discussion_r144851987, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFMFh2EXtt4Cg_L-wLNU7zSTDoEfPVyks5ss189gaJpZM4Pg9o2 .