A refactor into a separate single script file

lioneltrs / goNCommand

Bash script to convert 23 games (Ninja Commando, Ghost Pilots, Art of Fighting 3, Ninja Master's, Magician Lord, Crossed Swords, Sengoku, Super Sidekicks, The Last Blade 2, etc.) to romsets for Final Burn Neo

GNU General Public License v3.0

13 stars 2 forks source link

A refactor into a separate single script file #7

Closed RedundantCich closed 8 months ago

RedundantCich commented 1 year ago

I've done a couple changes to make extending the scripts easier:

separated the beginning of each file into a single separate script that is used by all others
made iflag arguments into a global inside the singular script file
changed rom ids to a global variable

Take a look if you're OK with those changes. If not, it's cool. If you would prefer to modify something, let me know in the comments to the PR.

Lx32 commented 1 year ago

I think that is a good idea, I'll try to improve this creating a general parametric script. Maybe I'll try to use python.

Lx32 commented 1 year ago

There is an error on 3 Count Bout graphics files. If I have time I'll try to check better. The CRC doesn't match.

RedundantCich commented 1 year ago

There is an error on 3 Count Bout graphics files. If I have time I'll try to check better. The CRC doesn't match.

You can use a tool i linked in the comments to convert these C files. Probably worth analysing how they are converted and moving the code to our repo

RedundantCich commented 1 year ago

There is an error on 3 Count Bout graphics files. If I have time I'll try to check better. The CRC doesn't match.

Turns out, it was an easy fix. I've update the file, and it just works now :) Thanks for the comment

domholmes commented 11 months ago

Nice work all. Looks like that might be the last of the games, at least for now.