search

lionheart / django-pyodbc

An ODBC-powered MS SQL Server DB backend for Django 1.4+
Apache License 2.0
203 stars 103 forks source link

Support Django 1.11 #151

Closed jallen1788 closed 6 years ago

jallen1788 commented 7 years ago

This is probably not complete, but it worked for my limited scope and may be a start.

Please send any advice and I might be able to more fully implement.

dlo commented 6 years ago

thank you @jallen1788! this looks great, only needs tests and then I think we'd be good to go.

gone commented 6 years ago

Anything I do to help move this along?

RossRogers commented 6 years ago

Well, I was actively working on releasing a Django 2.0-compatible alpha release when I got this email. Pypi is a pain.

On Thu, Feb 22, 2018 at 8:42 AM, Ben Beecher notifications@github.com wrote:

Anything I do to help move this along?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lionheart/django-pyodbc/pull/151#issuecomment-367742238, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_flGDnkyId6CThuAy-zgHA_iXQjGAlks5tXZkJgaJpZM4ODzL0 .

RossRogers commented 6 years ago

Hi Jared,

I just released alpha version 2.0.0a1. This is based on me getting the system to work for my codebase and we don't have other code coverage yet.. In order to get this release, please do pip install django-pyodbc==2.0.0a1.

See my commit message for more details: https://github.com/lionheart/django-pyodbc/commit/f510afd69be15ea18593ae6b4b14e0386eafa758

On Thu, Feb 22, 2018 at 8:49 AM, Ross Rogers ross.rogers@gmail.com wrote:

Well, I was actively working on releasing a Django 2.0-compatible alpha release when I got this email. Pypi is a pain.

On Thu, Feb 22, 2018 at 8:42 AM, Ben Beecher notifications@github.com wrote:

Anything I do to help move this along?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lionheart/django-pyodbc/pull/151#issuecomment-367742238, or mute the thread https://github.com/notifications/unsubscribe-auth/AD_flGDnkyId6CThuAy-zgHA_iXQjGAlks5tXZkJgaJpZM4ODzL0 .

RossRogers commented 6 years ago

Jared,

I have done basically the same edits as you here in support of Django 2.0 and released it as 2.0.0a1 on pip. Apologies for re-inventing the wheel, but I am going to close this pull request at this time. Please feel-free to re-open and comment on this ticket if I have misstepped.

jallen1788 commented 6 years ago

Good with me. Sorry, I haven't had time to clean this up, and wasn't very confident in the coverage of my solution. Yours looks much better.

RossRogers commented 6 years ago

Great!