Include dependencies in setup.py

lionheart / git-bigstore

Bigstore is a Git extension that helps you track big files in your repositories.

Apache License 2.0

183 stars 28 forks source link

Include dependencies in setup.py #24

Closed TRManderson closed 8 years ago

TRManderson commented 8 years ago

Most of your other packages could also do with this treatment honestly

dlo commented 8 years ago

I've done this in the past, but worried about overriding dependencies automatically from other projects that might be installed in the same virtual environment. Is there a way around that?

dlo commented 8 years ago

(BTW, thank you!)

TRManderson commented 8 years ago

That's actually a really important thing to bring up that I honestly hadn't considered. The best you can do is provide as loose a bound on version requirements as possible.

When it comes to Python, I primarily develop libraries rather than executables, so I'm used to trying to make the bounds loose, but executable development is a very different thing and I'm honestly not sure of best practices. Maybe just leave this PR sitting here for now :/

dlo commented 8 years ago

Will do. 😊

TRManderson commented 8 years ago

Just closing this because my knowledge hasn't progressed at all wrt this