search

lionheart / git-bigstore

Bigstore is a Git extension that helps you track big files in your repositories.
Apache License 2.0
183 stars 28 forks source link

Python 3 support #40

Closed dlo closed 5 years ago

MQQ commented 5 years ago

Hi there, just want to check if there is any plan or effort for this. If not, I can try to help. Thanks!

dlo commented 5 years ago

Hey @MQQ! So far, I haven't had the time, but if you're willing to, I'd be super happy to accept any PRs. :) Thank you!

MQQ commented 5 years ago

ok, I will see what I can do in the next week or two. :)

MQQ commented 5 years ago

@dlo Here is a quick PR for 2/3 compatible. #43

Notes: 1) The biggest problem is that python-cloudfiles is a very outdated package, and I can't find a straightforward replacement after quickly searching around. I myself also never used the rackspace cloud so I have no idea. I currently put a python2 marker in the setup.py so that python-cloudfiles will only be installed in python2, which means the rackspace backend will fail under python3.

2) I have to relax the version requirement for gitpython, since the old gitpython was also not compatible to python2. It seems the most recent gitpython==2.1.11 works fine.

Please let me know what you think. Thanks!

MQQ commented 5 years ago

@dlo Sorry for pushing this. But it would be great if this can be resolved earlier, which will really help my current project workflow. Thanks!

dlo commented 5 years ago

Hi @MQQ! Thanks again for contributing! I just had a few comments on the PR for you to take a look at. Otherwise everything looks great.

https://github.com/lionheart/git-bigstore/pull/43

MQQ commented 5 years ago

ah, I added a review comment a couple of days ago but I forgot to actually click the submit button. My bad :p

dlo commented 5 years ago

Just pushed up to PyPi. Thanks so much again!

MQQ commented 5 years ago

Great! Very happy to help!