search

lionheart / git-bigstore

Bigstore is a Git extension that helps you track big files in your repositories.
Apache License 2.0
183 stars 28 forks source link

Using bytes consistently for python 2 and 3 #44

Closed MQQ closed 5 years ago

MQQ commented 5 years ago

Hi @dlo ,

it seems that my last 2/3 compatible patch was not careful enough, since I didn't fully realize how stdin/stdout was used in the filter-clean and filter-smudge. In python 3, the stdin/stdout is by default in text mode, but not the binary mode, which is problematic. I have made some change to ensure that filter-clean and filter-smudge always deal with the input and output in binary model.

This is a critical bug in python 3. Sorry I didn't get to do enough tests before. But this patch should fix the problem. Thanks!

MQQ commented 5 years ago

@dlo Sorry for pushing this, but this is a critical issue in Python 3. Please let me know if you have any question.

MQQ commented 5 years ago

Happy to help!