search

lionheart / git-bigstore

Bigstore is a Git extension that helps you track big files in your repositories.
Apache License 2.0
183 stars 28 forks source link

Newly added files can't be directly pushed #45

Open MQQ opened 5 years ago

MQQ commented 5 years ago

It seems that change to an existing file in the repo can be git bigstore push correctly, but if I git add/stage a NEW file and add that file to .gitattributes, the git bigstore push won't directly work. I think the reason is that in the pathnames() function, it uses ls_tree to list all the files, but a new file won't be listed here since it hasn't been added to the tree?

I guess one way to solve that is to use ls_files with the stage option instead to list all the files. But I am not sure whether I missed something or I misunderstood the intentional workflow.

If this is actually a problem, I am happy to submit a patch.

dlo commented 5 years ago

Hmm, interesting. This might be a bug; do you have a good reproducible test case we can test against? I think the intended behavior should be what you're describing though, a patch would be great!