lionleaf / dwitter

Social network for short js demos
https://www.dwitter.net
Apache License 2.0
769 stars 69 forks source link

Polish dweet gif watermarks #332

Open lionleaf opened 6 years ago

lionleaf commented 6 years ago

Currently watermarks looks like this: gifs

There's been talk about changing them; either in minor ways, like moving them back to the top, adding a white bar at the bottom so they don't overlap the dweet (which would allow cropping for better or worse), or bigger features like various options to remove them for some users (maybe the author himself).

Making this issue to hear what the community has to say, and as a place for comments as more people start to actually use the feature.

joeytwiddle commented 6 years ago

My vote goes for an option to simply remove the watermark if the user doesn't want it.

Assuming it defaults to adding the watermark, In the UI we could offer a checkbox to the user:

Or alternatively:

(I guess I prefer the first one, but only slightly.)

I'm not sure where/when it would appear in the UI. Perhaps the checkbox could appear immediately after the user starts recording.

lionleaf commented 6 years ago

Do you envision this option being only for the author of the dweet, or should I be able to get a gif without watermark from your dweet?

It would seem reasonable for the user to be able to get gifs of their own dweets without a watermark. Just need to figure out a good UX around it :)

(And we should still make the watermark itself better for people who want it)

joeysino commented 6 years ago

Are these GIFs going to be used as the thumbnail that Twitter/Facebook display when someone shares a dweet?

If so, I think all the thumbnails should be consistent, and always hide the watermark (since the thumbnail will be connected to a link anyway).

joeysino commented 6 years ago

But if we are talking about users generating GIFs from other people's dweets, I personally don't mind users turning the watermark off. But it should default to on.

(Other authors might feel differently...)

lionleaf commented 6 years ago

@joeysino These are generated on the client side, so will not be used as thumbnails for social sharing. It's for users to generate and save as gif files and then manually post wherever they like