Closed lionleaf closed 2 years ago
The queryset changes introduced a bug causing a crash when generating the response to post_dweet, set_like and add_comment.
This commit fixes that issue, fixes a timezone warning, and adds tests that would have caught this before we hit prod. Better late than never.
I will emergency-merge this, as prod is broken. But happy to open new PR to respond to any code feedback, @sigvef
This does not fully fix https://github.com/dwitter-net/dwitter-frontend/issues/114 but fixes the underlying issue that caused it to be fully non-responsive
When opening your Pull Request, we encourage you to do the following (you can add an X to check each task):
make lint
The queryset changes introduced a bug causing a crash when generating the response to post_dweet, set_like and add_comment.
This commit fixes that issue, fixes a timezone warning, and adds tests that would have caught this before we hit prod. Better late than never.
I will emergency-merge this, as prod is broken. But happy to open new PR to respond to any code feedback, @sigvef
This does not fully fix https://github.com/dwitter-net/dwitter-frontend/issues/114 but fixes the underlying issue that caused it to be fully non-responsive
When opening your Pull Request, we encourage you to do the following (you can add an X to check each task):
make lintto ensure that all the files are formatted and using best practices.