search

lionsharecapital / lionshare-api

Realtime cryptocurrency API
263 stars 48 forks source link

Throttle websocket to prevent clients from drowning in data #44

Closed FiberJW closed 7 years ago

FiberJW commented 7 years ago

This should help with lionshare performance by slowing down the faucet of data.

FiberJW commented 7 years ago

Yeah, sorry. Prettier autoformatted the files. Wouldn't mind submitting a pr to fully support Prettier in this codebase so that there's one unified code style. On Wed, Jul 5, 2017 at 1:24 PM Maksim Stepanenko notifications@github.com wrote:

@maksim-s requested changes on this pull request.

thanks @fiber-god https://github.com/fiber-god! 👏 Can you please remove the stylistic changes from this PR? While I like them, I don't want the project to end up with inconsistent style between different files. If you feel strongly about it, would love to see a PR updating all the files.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lionsharecapital/lionshare-api/pull/44#pullrequestreview-48122296, or mute the thread https://github.com/notifications/unsubscribe-auth/AL6QetC68Ki6Yas8lYHkteS9uggl4PClks5sK8bDgaJpZM4OLXlV .

maksim-s commented 7 years ago

a separate PR with prettier would be awesome!

FiberJW commented 7 years ago

Just submitted #45. Will update this branch based on that PR if merged.

FiberJW commented 7 years ago

Everything should be consistently styled now

maksim-s commented 7 years ago

thank you!