search

lionsharecapital / lionshare-desktop

🦁 Simple cryptocurrency price and portfolio monitor for macOS
https://lionshare.capital
MIT License
568 stars 76 forks source link

fix currency format for different locale #67

Open alepop opened 7 years ago

alepop commented 7 years ago

Locale currency was breaking by numeraljs and regex. I tried to fix it using only native Intl.NumberFormat. But they are open question about currency symbol position. In some localization, symbol staying in the end of digits and it break the app design. fix #64 #50

jorilallo commented 7 years ago

@jpmgoncalves would you mind trying this out? Looks like you had this issue a while ago. @jenbennings and you if you happen to have aussie locale, I remember there being something weird

jpmgoncalves commented 7 years ago

Should I download the newest version to try it out @jorilallo?

k06a commented 7 years ago

@jpmgoncalves just checked, it helps. Please merge it and build a new release.

2017-04-29 23 02 15

jpmgoncalves commented 7 years ago

@k06a, I don't have permissions to do that.

alepop commented 7 years ago

@maksim-s can you review this PR?

alepop commented 6 years ago

Almost one year passed and pr still not reviewed T_T