Branches for es older than v6.8 read binary source as double[] - contrary to README

lior-k / fast-elasticsearch-vector-scoring

Score documents using embedding-vectors dot-product or cosine-similarity with ES Lucene engine

Apache License 2.0

395 stars 112 forks source link

Branches for es older than v6.8 read binary source as double[] - contrary to README #39

Open thenomadlad opened 4 years ago

thenomadlad commented 4 years ago

Was there a reason the branches for es-6.8 onwards were the only ones updated to parse the embedding field into floats instead of doubles?

I think we should either fix the plugin for all versions to interpret the field as float[], or clarify it in the readme. I have an easy enough patch to update the older version branches.

lior-k commented 4 years ago

no reason. If you can submit a PR go ahead. I would appreciate the help. Just make sure unit tests pass. Thanks