search

liormizr / s3path

s3path is a pathlib extension for AWS S3 Service
Apache License 2.0
208 stars 39 forks source link

Remove S3DirEntry from `__all__` #134

Closed gabrieldemarmiesse closed 1 year ago

gabrieldemarmiesse commented 1 year ago

It seems it cannot be accessed from the public api, I don't know why it's there. Should we make it private?

liormizr commented 1 year ago

Hi @gabrieldemarmiesse

You are right :-)

I'll clean it up

Thank you

liormizr commented 1 year ago

PR: #138

liormizr commented 1 year ago

Merged to master I'll close this issue when we will deploy the next version

Tx

liormizr commented 1 year ago

Deployed in version 0.5.0

cooperlees commented 1 year ago

How is one meant to type making generators that return _S3DirEntry now _S3DirEntry is "private"?

PR upgrading bandersnatch to s3path to 0.5.0: https://github.com/pypa/bandersnatch/pull/1525