search

liormizr / s3path

s3path is a pathlib extension for AWS S3 Service
Apache License 2.0
207 stars 39 forks source link

writelines method is not compliant with base same method from file. #52

Closed Darkheir closed 3 years ago

Darkheir commented 3 years ago

To be compliant with the base writelines method the new line character should not be added.

From the documentation https://docs.python.org/2/library/stdtypes.html#file.writelines :

The name is intended to match readlines(); writelines() does not add line separators.

There is also an issue where the double call to _string_parser (once in writlines and then in write) raising an error:

TypeError: a bytes-like object is required, not 'str'

liormizr commented 3 years ago

Merged the fix, well done I'll update when we will deploy a new version (2 days tops)

liormizr commented 3 years ago

Version 0.2.203 deployed with this fix

liormizr commented 3 years ago

@Darkheir is this issue still relevant or can we close it?

Darkheir commented 3 years ago

Yes we can close it. Thank you for the reactivity!