Issue in S3KeyReadableFileObject line iteration

liormizr / s3path

s3path is a pathlib extension for AWS S3 Service

Apache License 2.0

207 stars 39 forks source link

Closed Darkheir closed 3 years ago

Darkheir commented 3 years ago

A few issues regarding the lines handling in S3KeyReadableFileObject:

Everytime readline is called a new generator is created from _streaming_body.iter_lines
The __next__ method is calling readline and this method never raises StopIteration
readlines is iterating over readline that never raises StopIteration

liormizr commented 3 years ago

Merged the fix, well done I'll update when we will deploy a new version (2 days tops)

liormizr commented 3 years ago

Version 0.2.203 deployed with this fix

liormizr commented 3 years ago

@Darkheir we can close this issue right?

Darkheir commented 3 years ago

Yes, we can close it! Thank you for your work !