search

liormizr / s3path

s3path is a pathlib extension for AWS S3 Service
Apache License 2.0
209 stars 41 forks source link

Warning from smart_open #69

Closed maresb closed 3 years ago

maresb commented 3 years ago

I'm seeing the following warning. At the moment I don't have time to track it down, but maybe this is already enough to understand the problem?

/opt/conda/lib/python3.9/site-packages/smart_open/s3.py:220: UserWarning: ignoring the following deprecated transport parameters: ['multipart_upload_kwargs', 'object_kwargs', 'resource_kwargs', 'session']. See <https://github.com/RaRe-Technologies/smart_open/blob/develop/MIGRATING_FROM_OLDER_VERSIONS.rst> for details
  warnings.warn(message, UserWarning)
liormizr commented 3 years ago

Hi @maresb I know about this warning For now (the first version of s3path with smart-open) I wanted that the library will support old and new versions of smart-open.

We already have users that work with s3path and smart-open and I didn't want to force them to change there smart-open requirements.

maresb commented 3 years ago

Ok, thanks. Then I assume it can be safely ignored.

liormizr commented 3 years ago

Next version I'll change the code that will behave according to the smart-ioen version.

I'll update here with version number when I'll finish

liormizr commented 3 years ago

Deployed Version: 0.3.02