liouh / picross

Playable picross puzzle generator written in JavaScript
66 stars 25 forks source link

Add dark mode to the grid #3

Closed Pustur closed 5 years ago

Pustur commented 5 years ago

Hi, the new dark mode is a very welcome addition, so thanks for that!

However I think that we can make it even better by extending the dark mode to the actual grid as well. As it is right now it's a bit too bright compared to everything else in my opinion.

This PR is a proposal, I'm not sure if I covered all the cases so maybe some more testing is needed.

Here's before:

Screenshot 2019-08-16 at 01 10 50

And after:

Screenshot 2019-08-16 at 01 17 47

What do you think?

liouh commented 5 years ago

The colors you chose look good, however, you're right that it does miss some cases:

I think it comes down to the fact that using body.dark as additional specificity really isn't a great solution. Two better alternatives:

  1. Break out the grid styles into separate CSS files and update the link href in response to theme changes.
  2. Apply a body.light rule to the default grid styles (with JS changes to match), so we prevent inadvertent style overrides.

I can also imagine a test.html file that preview all puzzle states at once for testing purposes.

I'm going to close this pull request, but may come back and use the colors you've selected :)