Upgrade deps - Githubissues

lipanski / mockito

HTTP mocking for Rust!

MIT License

695 stars 59 forks source link

Upgrade deps #134

Closed kornelski closed 3 years ago

kornelski commented 3 years ago

mockito$ cargo upgrades All dependencies are up to date!

lipanski commented 3 years ago

@kornelski thanks for the PR! seems like the 1.36 toolchain build is failing on the env_logger upgrade - see Travis. #[non_exhaustive] was stabilized in 1.40 as far as I see.

at this point I wouldn't have anything against increasing the min. supported toolchain to 1.40, which implies:

Changing all occurences of 1.36 in the README.md and travis.yml
Re-running clippy for the new min. supported toolchain: rustup run --install 1.40.0 cargo clippy --lib --tests --all-features -- -D clippy::pedantic -D clippy::nursery

alternatively you could also find an env_logger version that works with 1.36.

kornelski commented 3 years ago

It's failing on pedantic clippy lints, which are turned into errors. I don't think it's a good idea to treat every pedantic suggestion (many of which are meaningless or wrong) as stop-the-build catastrophic error.

lipanski commented 3 years ago

It's failing on pedantic clippy lints, which are turned into errors. I don't think it's a good idea to treat every pedantic suggestion (many of which are meaningless or wrong) as stop-the-build catastrophic error.

feel free to disable the pedantic check in Travis (also in the README please), I know it can be a pain.

kornelski commented 3 years ago

Ok, I've managed to make it a proper Travis Job.

lipanski commented 3 years ago

@kornelski thanks! the Travis jobs look lovely, though I trimmed some things down in https://github.com/lipanski/mockito/pull/136

released with 0.29.0 :rocket: