search

lipanski / mockito

HTTP mocking for Rust!
MIT License
670 stars 57 forks source link

libcurl dependency #19

Closed lipanski closed 7 years ago

lipanski commented 7 years ago

dev-dependencies cannot be opted out (see this) and the libcurl dependencies poses problems when cross-compiling the crate.

originall reported here.

cc @lucab I'll try to think of something but I went for curl & http-muncher because the hyper server doesn't work on Windows (maybe I'll just use TcpStream + hyper only as a parser). libcurl is also way faster apparently.

estin commented 7 years ago

And my thoughts about libcurl.

libcurl used only for making http POST requests to the mock server launched in the thread.

May use async channel to comunicate in threads to add/remove/reset mocks without http and serailization/desirailization? Like https://tokio.rs/docs/going-deeper-futures/synchronization/#channels

Sorry for my poor English.

lucab commented 7 years ago

I guess @estin suggestion above is somehow tangled into the larger discussion of making mockito testthread-local. Whatever we'll end up doing here, it would be nice if it'd also account for that.

lipanski commented 7 years ago

@estin @lucab a great day for Mockito :tada:

0.8.0 removed the need for curl (and serde for that matter).

please check the changelog because with 0.7.0 I introduced some breaking changes, but also some new features.

lucab commented 7 years ago

👍 Thanks for pinging back, I'll give it a try soon.