search

lipas-liikuntapaikat / lipas

Lipas is a nationwide, public GIS service of Finnish sport and recreation facilities.
MIT License
70 stars 14 forks source link

Sorting click: ascending if sorting by a new column #90

Closed t-my closed 11 months ago

t-my commented 11 months ago

https://trello.com/c/SiKs9Jwb/47-sorttausklikkauksen-toiminta

vharmain commented 11 months ago

Thanks! The change looks good. 👍

🧑‍🎓 Educational nitipcking:

The tests themself are quite trivial but the docstrings in testing blocks describe the behaviour really well. Could the same be achieved by writing the code itself like "if sort-fn has changed, reset sort order to ascending"?

Also, please either make the tests run or delete them. Otherwise they're just "dead code" in the codebase. :)