[Bug] +/- Modifier-Buttons not working

lipefl / swade-tools

A Fondry VTT module with automations for Savage Worlds (SWADE)

15 stars 13 forks source link

[Bug] +/- Modifier-Buttons not working #273

Closed Vogliadicone closed 9 months ago

Vogliadicone commented 9 months ago

The plus and minus buttons on the roll card aren't working. They worked in he past, but no idea, when and why they stopped to work. This applies to all roll cards (skills, attacks and powers). error

I can reproduce the problem in a test world with only SWADE and SWADE Tools.

Foundry VTT: 11.315 (in the OracleCloud)
Swade System: 3.2.4
Swade Tools 1.14.7
Browser: Google Chrome (same issue with Edge)

Vogliadicone commented 9 months ago

It might be connected to this bug in SWADE core or might even be the same: https://gitlab.com/peginc/swade/-/issues/997

Vogliadicone commented 9 months ago

The problem also occurs with SWADE core 3.2.5. So It wasn't related to core issue 997.

mrcomac commented 9 months ago

I trust there is a typo

Error:

gb.js:97 Uncaught ReferenceError: gb is not defined
    at HTMLButtonElement.<anonymous> (gb.js:97:21)
    at HTMLDivElement.dispatch (jquery.min.js:2:43184)
    at y.handle (jquery.min.js:2:41168)

Line 97:

 let val=gb.realInt(input.val());

Fix suggestions: option 1

 let val=realInt(input.val());

option 2

let val=parseInt(Number(input.val()));

lipefl commented 9 months ago

Fixed in v1.14.8 Thanks!