search

lipefl / swade-tools

A Fondry VTT module with automations for Savage Worlds (SWADE)
15 stars 13 forks source link

broken end of turn sequence behavior #289

Closed sebertram847 closed 5 months ago

sebertram847 commented 6 months ago

Only loading SWADE Tools mod. Scenario: 2+ actors in the combat tracker, make all (or the right one) Stunned. End the round. One actor (and only ever one) will get 2 free rolls to unshake before cards are dealt. If both rolls succeed, the 2nd one throws an error since the condition was removed by the first. I cannot figure out why this happens.

Further research is that the stunned condition is not the issue, it's only proving that at the end of the turn, one combatant goes through 2 or 3 other turn sequences before the beginning of the next round. Something in combatcontrol.js or start.js?

image

lipefl commented 6 months ago

It seems like they changed combat a little, it could get fixed by itself in the next system updates, but i'll see what can be done.

sebertram847 commented 6 months ago

I looked over start.js and combatcontrol for an obvious hack but I don’t know enough about the eventing structure of foundry to be useful. The way the turn counter goes back to zero at the end of a round broke my brain.

It’s not a game breaker issue but thanks for taking a look at it.

Also this toolkit is great. Thanks for providing it!

On Tue, Mar 5, 2024 at 6:58 AM lipefl @.***> wrote:

It seems like they changed combat a little, it could get fixed by itself in the next system updates, but i'll see what can be done.

— Reply to this email directly, view it on GitHub https://github.com/lipefl/swade-tools/issues/289#issuecomment-1978723211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANLJLCTW2P6OW2VMKCSL6J3YWW6OPAVCNFSM6AAAAABEGGZFBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYG4ZDGMRRGE . You are receiving this because you authored the thread.Message ID: @.***>

lipefl commented 5 months ago

I wasn't able to reproduce it anymore. I think it fixed itself in the system update.

sebertram847 commented 5 months ago

Actually I can still reproduce it. At the end of the round one character gets 2 tries to unshake before the new round starts. Same as above.

lipefl commented 5 months ago

You're right, i'll look into it. Thanks

lipefl commented 5 months ago

It's fixed now in v1.15.1 Thanks again!

sebertram847 commented 5 months ago

Yep, works great. Thanks!