search

lipengyu / strategico

Automatically exported from code.google.com/p/strategico
GNU General Public License v3.0
0 stars 0 forks source link

ltp.R must not read data from the environment (see occurrences of the CONFIG variable) #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
ltp.R should contain functions that do not read data from the environment: at 
the moment some info are taken from CONFIG variable.

Please, remove it, maybe adding new inut parameters to the funcions

Original issue reported on code.google.com by matteo.redaelli on 6 Jan 2011 at 1:33

GoogleCodeExporter commented 9 years ago 
mi pare di aver fatto, da un occhio. solo ltp.HTMLreport usava CONFIG, ora l'ho 
messo come parametro

Original comment by livio.finos on 13 Jan 2011 at 5:59

GoogleCodeExporter commented 9 years ago 
si, ho visto .. ma forse devi modificare anche eval_ltp e richiamare la 
funzione ltp passandole CONFIG....  

 eval_ltp.R:    if("report"%in%CONFIG$save) ltp.HTMLreport(model, keys, value,param,directory)

ltp.R:ltp.HTMLreport <- function(obj, keys, 
value,param,directory=NULL,CONFIG=CONFIG) {

Original comment by matteo.redaelli on 13 Jan 2011 at 7:28

GoogleCodeExporter commented 9 years ago 
IN verita' ho dovuto ritogliere il parametro. ottenevo un errore

Error in paste(.get_item_name(keys), CONFIG$values[value], sep = " - ") : 
  promise already under evaluation: recursive default argument reference or earlier problems?

come alternativa, credi sia concettalmente corretto spostare la funzone del 
report html da ltp.R ad eval_ltp.R? in questo modo possiamo dare x scontato 
CONFIG ..

Original comment by matteo.redaelli on 14 Jan 2011 at 9:21

GoogleCodeExporter commented 9 years ago 
ho aggiunto un nuovo parametr nella funzione HTMLreport e ho cosi' eliminato 
l'uso di CONFIG

Original comment by matteo.redaelli on 21 Jan 2011 at 9:01