search

lipido / kargos

KDE Plasma port of GNOME Argos and OSX BitBar
GNU General Public License v3.0
126 stars 13 forks source link

Request: Dropdown never visible mode #14

Closed AndydeCleyre closed 4 years ago

AndydeCleyre commented 6 years ago

Panel space is precious, so I would prefer not to take up extra space just for the dropdown button, which is a visual cue but acts the same as any other part of the my applet when clicked.

The current hidden-mode behavior of showing the dropdown icon whenever the dropdown is shown and hiding again when the dropdown is hidden makes the entire panel resize with each click, which is really jarring and unpleasant and affects many other applets.

roachsinai commented 5 years ago

Yes, can't agree anymore. Found there is a shadow effect under the panel whenever the dropdown is shown, so I think that's is enough as a reminder. So wish you to remove the visible option, or give a choice to set never visible.

roachsinai commented 5 years ago

Have chaged 2 places reverse the bool value, but failed to hide button. lol.

https://github.com/lipido/kargos/blob/d5603d1aeb621add425a659344fe772ea9b3b497/plasmoid/contents/ui/ItemTextMouseArea.qml#L38

https://github.com/lipido/kargos/blob/d5603d1aeb621add425a659344fe772ea9b3b497/plasmoid/contents/ui/CompactRepresentation.qml#L163

roachsinai commented 5 years ago

https://github.com/lipido/kargos/blob/d5603d1aeb621add425a659344fe772ea9b3b497/plasmoid/contents/ui/CompactRepresentation.qml#L70

change to visible: false worked. And you could also add a checkbox at file ConfigAppearance.qml to control it.

roachsinai commented 5 years ago

Made a pull request, check it! #26