search

lipido / kargos

KDE Plasma port of GNOME Argos and OSX BitBar
GNU General Public License v3.0
126 stars 13 forks source link

Replace fancy ES6 format string with regular string concat #38

Closed shocklateboy92 closed 4 years ago

shocklateboy92 commented 4 years ago

I'm thinking since Qt 5.9 was only released in 2018, its bundled JS interpreter doesn't support ES2017 format strings.

Hopefully, this fixes #37

lipido commented 4 years ago

In my case, this now avoids the exception. However, I don't see the command passed by the command line (plasmoidviewer -a ./plasmoid "echo hello world"). Is it possible that the argument is passed to the plasmoid from an specific version? In any case, I think that this PR can be merged, since it removes the exception, which is crucial.

shocklateboy92 commented 4 years ago

Looks like it was added in v5.8.95: https://github.com/KDE/plasma-sdk/commit/83d18d60ec8d781e69a06d7463abb511a9c04d84 Do the commands mentioned in that commit work for you?

PS: What timezone are you in? (I'm in PST). You should join the matrix channel I added to the bottom of our readme.md so we can coordinate stuff better.