Build red on Windows

[GoogleCodeExporter]

Right now there are 10 Failures and 4 Errors on Windows. There are some 
functional failures which look smelly. This may mean that our Windows support 
is dodgy. Need to take a closer look at the failures.

Original issue reported on code.google.com by singh.janmejay on 17 Dec 2010 at 7:56

[GoogleCodeExporter]

Original comment by itspa...@gmail.com on 17 Jan 2011 at 8:46

• Added labels: Milestone-0.3, OpSys-Windows, Priority-Critical
• Removed labels: Priority-High

[GoogleCodeExporter]

We had a lot of hardcoded '\n' and '/' in the tests. This is a big no-no on 
Windows. The standard trick of new File("/whatever/path/you/want").getPath() 
should be enough. Consistently use '\n' everywhere or the 
System.getProperty("line.separator", "\n") everywhere. The idea is that we 
should not depend on the line separator on a file to be "\n". 

We were also using "|" in file names in production which was actually a bug. 
Windows does not support that. Changed it to be "_" and took care of escaping.

There is still an issue with reading a file that was modified by users on 
Windows where in the file would automatically use "\r\n" for newlines. But, we 
will cross that bridge when we get there.

All tests are passing locally right now. Marking this as closed. We may need to 
setup an agent running on Windows and point it to cruise01 to make sure we do 
CI on Windows.

Original comment by itspa...@gmail.com on 17 Jan 2011 at 6:47

• Changed state: Fixed