lipinggm / tlb

Automatically exported from code.google.com/p/tlb
0 stars 0 forks source link

Mutual Exclusion was broken while Time balancing with smoothing #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
    For the jobs firefox-2 and firefox-3, the mutual exclusion criteria was broken. The actual suite times are as follows:

    PipelineSelector.scn: 157638
    AgentsApi.scn: 100931
    AddNewEnvironmentFormAndTabs.scn: 48580
    Agent UI Auto Refresh.scn: 60964
    EnvironmentsScreenPermissions.scn: 34828
    PipelineGroupAdmins1.scn_row_1: 87441
    AssociateUsersWithRoles.scn: 39918
    PipelineXml.scn: 632594
    PipelineDependencyChaining.scn: 348389
    EnvironmentsScreenNoMaterialName.scn: 135660
    BuildCause.scn: 208719
    StageDetailsJobTab.scn: 81144
    SmokeTest.scn: 173826
    PipelineDependencyWithDependencyMaterialAtHop.scn: 170295
    EditAnExistingEnvironment.scn: 25386
    PipelineUnlocking.scn: 142210
    Passed Builds Do Not Have Failed Build History.scn: 253591
    Dashboard-FilterFiles.scn: 459231
    UserAdmin.scn: 55983
    SearchAndAddUser.scn: 42540
    AccessingAUrlAsAnOAuthClient.scn: 1074939
    EnableDisableUsers.scn: 57865
    EnvironmentPipelineLocking.scn: 328798
    ServerConfigurationTabMailHost.scn: 2053909
    EnvironmentsScreen.scn: 131085
    RescheduleJob.scn: 1997142
    PageFooterAndHelp.scn_row_1: 64455
    BasicParamSubstitutionWithTemplate.scn_row_1: 86932
    AgentResources.scn: 94195
    AdministrationApiSecurity.scn: 53048
    StageDetailPipelineDependenciesTab.scn: 183932
    AgentsWithSameUUID.scn: 124334
    MaterialSupport.scn_row_0: 97805
    JobDetailsBreadCrumbs.scn: 87428
    AgentsUIScreen.scn: 353157
    StageDetailsShineIntegrationWithoutSecurity.scn: 44798
    ArtifactAndPropertiesSecurity.scn: 55648
    StageDetailsMaterialInfo.scn: 1061573
    SvnPipeline.scn: 272178
    AddNewEnvironment.scn: 49466
    PipelineGroupAdminsForNonAdmin.scn_row_1: 274687
    PipelineGroupAdmins3.scn: 93336
    PipelineGroupAdminsForUserWithNoPermission.scn: 101438
    BasicParamSubstitution.scn: 67816
    AllowOnlyKnownUsersToLogin.scn: 30164
    SpecificRevisionOfPipeline.scn: 87871
    StageDetailsShineIntegration.scn: 153545
    PipelineGroupPermissionsForUserWithOperateViewAndAdmin.scn: 57170
    PipelineApis.scn: 233348
    AdvancedParamSubstitution.scn: 20851
    NantTask.scn: 207124
    PipelineDependencyForBug3957.scn: 336491
    PipelineDetailsTriggerDownstream.scn: 145650
    NewShouldShowPasswordAsStarInMaterialTabAndConsoleOutputAndPopup.scn: 66082
    PipelineGroupAdmins2.scn_row_1: 96985
    ServerConfigurationTabLicenseForm.scn: 14699
    StageDetailsHistoryPagination.scn: 165461
    StageDetails.scn: 217918
    PipelineLayoutOperatePermissions.scn: 109122
    JobTaskConditions.scn: 69599
    NewCruiseLicense.scn: 17679
    StageDetailsJobTabAutoRefresh.scn: 95898
    AssociatingAPipelineWithAnEnvironmentWithNoAgents.scn: 206627
    PassEnvironmentVariablesToAJob.scn: 464585
    PipelineGroupPermissionsForUserWithOperateAndAdmin.scn_row_1: 101725
    RerunStage.scn: 2036913
    GitPipeline.scn: 91967
    AssociatingMultiplePipelinesWithAnEnvironment.scn: 179210
    PipelineGroupAdminsWithStageSecurity.scn: 66937
    StageDetailsForPipelineLock.scn: 79705
    FeedApis.scn: 82623
    JobsOnMatchingAgents.scn: 101890
    EnvironmentsScreenNavigation.scn: 89397
    JobProperties.scn: 60830
    PIpelineLockingOnDashboard.scn: 81285
    CreatePipelineWithWizard.scn: 17804
    AddNewEnvironmentValidationsAndShow.scn: 48429
    CruiseErrorMessages.scn: 187726
    KillProcessTreeWhenStageCancel.scn: 67130
    PipelineApiSecurity.scn: 136264
    TimerWithPipelineDependencies.scn: 179749
    EditAnExistingEnvironmentNegativeCase.scn: 34768
    PageFooterAndHelp.scn_row_0: 47060
    StageDetailsAutoRefresh.scn: 61456
    PipelinesUsingTimer.scn: 148399
    PipelineGroupAdminsForNonAdmin.scn: 48314
    StageSecurity.scn_row_1: 98490
    AgentInEnvironmentShouldNotSchedule.scn: 212648
    AdminRolesAndUsers.scn: 113495
    StageWithFetchMaterialsAttribute.scn: 114429
    ServerConfigurationTabUserManagement.scn: 32747
    Materials For Pipelines Are Wired Correctly.scn: 43588
    ArtifactUploadFetch.scn: 88623
    PipelineDependency.scn: 364181
    GlobalMessages.scn: 48440
    OAuthCRUDOperations.scn: 733695
    PipelineDependencyTriangle.scn: 197523
    EnvironmentsScreenAutoRefresh.scn: 138511
    JobEnvironmentVariables.scn: 89778
    PipelineDependencyChainingWithIgnoreFilters.scn: 358498
    LicenseUserLimitEnforcement.scn: 146538
    StageWithCleanWorkingDIrAttribute.scn: 70661
    PipelineLayoutStageActions.scn: 250696
    OAuthAccessTokenShouldBeTiedToTheUser.scn: 26599
    CreatePipelineApiSecurity.scn: 18924
    CCTrayFeed.scn: 98333
    SeeWhatActuallyChangedSinceTheLastPipelineRun.scn: 65695
    PipelineDashboard.scn: 264960
    StageSecurityForAutoApproval.scn_row_1: 94379
    PipelineDetailsPage.scn: 172828
    PipelineGroupAdminsForSuperAdmin.scn: 86624
    ShowAgentsTotal.scn: 38615
    BisectingPipelines.scn: 118868
    PipelineScheduling.scn: 57085
    StageLocking.scn: 101645
    PipelineGroupPermissionsForUserWithViewAndAdmin.scn_row_1: 103385
    PipelineDashboardAutoRefresh.scn: 197912
    UserLicenseValidation.scn: 78185
    PipelineUnlocking-ErrorMessages.scn: 21787
    MaterialSupport.scn_row_1: 112834
    OAuthScenariosWhenClientIsRemoved.scn: 1960279

    The following were the environment variables for: 
    firefox-3

    TimeBasedTestSplitterCriteria

    [cruise] setting environment variable 'TLB_CRITERIA' to value 'com.github.tlb.splitter.DefaultingTestSplitterCriteria'
    [cruise] setting environment variable 'CRITERIA_DEFAULTING_ORDER' to value 'com.github.tlb.splitter.TimeBasedTestSplitterCriteria:com.github.tlb.splitter.CountBasedTestSplitterCriteria'
    [cruise] setting environment variable 'TLB_ORDERER' to value 'com.github.tlb.orderer.FailedFirstOrderer'
    [cruise] setting environment variable 'TLB_TMP_DIR' to value '/tmp'
    [cruise] setting environment variable 'load_balance' to value 'yes'
    [cruise] setting environment variable 'TOTAL_PARTITIONS' to value '6'
    [cruise] setting environment variable 'TLB_URL' to value 'http://go03.thoughtworks.com:7019'
    [cruise] setting environment variable 'TALK_TO_SERVICE' to value 'com.github.tlb.service.TalkToTlbServer'
    [cruise] setting environment variable 'JOB_VERSION' to value '${GO_PIPELINE_COUNTER}-${GO_STAGE_COUNTER}'
    [cruise] setting environment variable 'TLB_JOB_NAME' to value '${GO_PIPELINE_NAME}-twist-firefox'
    [cruise] setting environment variable 'USE_SMOOTHING' to value 'true'
    [cruise] setting environment variable 'PARTITION_NUMBER' to value '3'

Original issue reported on code.google.com by singh.janmejay on 17 Dec 2010 at 8:08

GoogleCodeExporter commented 9 years ago
The next time we face this issue, we need to make sure that the number of jobs 
was in sync with the TOTAL_PARTITIONS. We need to capture that information in 
the bug report.

Original comment by itspa...@gmail.com on 31 Dec 2010 at 4:55

GoogleCodeExporter commented 9 years ago
Not enough data to reproduce this issue. Lets keep an eye out for this. 
However, when the issue#21 is implemented, these kind of bugs should not 
happen. We know there is a bug lurking when all the partitions are not running 
on the same version of JVM (may not happen, but we need to test it out) because 
we relay on sorting by Collections.sort. One way to mitigate this is to write a 
comparator that never returns 0. Will create a new bug for that and close this 
as invalid.

Original comment by itspa...@gmail.com on 17 Jan 2011 at 8:54