lipiridi / webflux-logging

Java library for logging incoming HTTP requests in Spring WebFlux applications
MIT License
0 stars 0 forks source link

Call to LogConsumers does not precede call to LOG #1

Closed mchatzip-telekom closed 1 month ago

mchatzip-telekom commented 1 month ago

I found in your LoggingWebFilter class that you apply the changes to the httpLog AFTER it is already logged. I think it might be an oversight, I locally flipped the forEach(consumer::accept) line with the LOG.info(...) line and all worked as expected.

lipiridi commented 1 month ago

Hi @mchatzip-telekom Thank you for the first issue😃 This feature wasn't intended to allow modifications to the HTTP log. What I had in mind during implementation was saving the log to external storage. Let me adjust the flow to meet your expectations and update the description. I'll notify you once it's done.

lipiridi commented 1 month ago

@mchatzip-telekom version 1.0.1 was released - https://central.sonatype.com/artifact/io.github.lipiridi/webflux-logging/1.0.1