lipis / bootstrap-social

:couple: Social Sign-In Buttons for Bootstrap
https://lipis.github.io/bootstrap-social/
MIT License
2.91k stars 821 forks source link

Facebook sign-in branding not compliant #178

Open holtkamp opened 5 years ago

holtkamp commented 5 years ago

Similar to https://github.com/lipis/bootstrap-social/issues/177,

just received an e-mail from Facebook:

Hi,

In working to create a great Platform experience for everyone, we ask developers to ensure the apps they build comply with our Platform Policies. Your app X (AppId: Y) doesn't comply with the following:

Platform Policy 8.3: Use a clearly branded "Login with Facebook" button and follow the Facebook Brand Guidelines: https://www.facebookbrand.com/.

Your Login button doesn't properly reference Facebook. To fix this issue, you should always use our official SDK for Login. For more information on Login best practices, check out the Login section of our developer documents: https://developers.facebook.com/docs/facebook-login/best-practices#buttondesign.

You can access the full list of our Platform Policies here: https://developers.facebook.com/policy/.

Please make the requested changes by <7 days later>.

Let us know when you've updated your app by replying to this email. If we do not hear back from you, your app will be subject to enforcement. If you have outstanding questions, respond here and we'll do our best to help.

Thanks,

When responding we use the "standard" https://github.com/lipis/bootstrap-social the response was:

Unfortunately, the button is not compliant with our Platform Policies. We would kindly ask you to use the button from https://developers.facebook.com/docs/facebook-login/best-practices#buttondesign , just to avoid any possible user confusion. We thank you for your understanding!

I also found:

https://developers.facebook.com/docs/facebook-login/userexperience#buttondesign which states:

I suggested that Facebook helps the community by contributing their suggested changes / improvements to this component...

Update @lipis in a reply, the Facebook support team indicates that only having "Facebook" as content is not a problem. It is the "branding", so I guess mainly the background color. I can submit a pull request for the background color change, would that be considered for merge?

Update 2 In summary, the requested changes are:

holtkamp commented 5 years ago

Disclaimer: I am not a designer, but for the time being the following workaround might be viable:

.btn-social.btn-facebook {
    background-color: #4267B2;
}
.btn-social.btn-facebook > :first-child {
    color: #4267B2;
    background-color: white;
    border-radius: 1px;
    text-align: right;
    margin: 4px;
    border-right: none;
    width: 24px;
    padding-right: 2px;
    padding-top: 3px;
    line-height: normal;
}
Screenshot 2019-04-15 at 10 29 17

Further improvements are welcome. Maybe this "alternative" can be adopted in this library?

TheDevMinerTV commented 5 years ago

Make a Pull Request and be happy 😄