search

lipis / flag-icons

:flags: A curated collection of all country flags in SVG — plus the CSS for easier integration
https://flagicons.lipis.dev
MIT License
10.66k stars 1.85k forks source link

`<radialGradient />` without stops #1162

Open normanzb opened 11 months ago

normanzb commented 11 months ago

hi there ,

below file contains a few radial graident elements but without any stop inside, are they indended? they are causing warnings when used in react native.

https://github.com/lipis/flag-icons/blob/6784329d3fa1466fb8ef184ac69b021a45691271/flags/1x1/bz.svg#L14

simliar issues can be found in 4x3, fk, gs, ni, gt and mx

lipis commented 11 months ago

To be honest we got them most likely from Wikipedia and then parsed with SVGO! We don't manually edit the SVG unless is just colors updates... if you know how to fix the issue, feel free!

SethFalco commented 11 months ago

It doesn't have any stops defined itself because it's inheriting the stops from the referenced radialGradient above.

<radialGradient id="bz-b">
  <stop offset="0" stop-color="#952d1a"/>
  <stop offset="1" stop-color="#570a00"/>
</radialGradient>
<!-- … -->
<radialGradient xlink:href="#bz-b" id="bz-e" cx="364.2" cy="237.8" r="36" fx="364.2" fy="237.8" gradientTransform="scale(1.2242 .81686)" gradientUnits="userSpaceOnUse"/>
<radialGradient xlink:href="#bz-b" id="bz-f" cx="468.1" cy="156.1" r="10.7" fx="468.1" fy="156.1" gradientTransform="scale(.95596 1.04607)" gradientUnits="userSpaceOnUse"/>

This may be worth reporting to the React Native, or whatever is issuing this warning.