search

lipis / flag-icons

:flags: A curated collection of all country flags in SVG — plus the CSS for easier integration
https://flagicons.lipis.dev
MIT License
10.78k stars 1.86k forks source link

Possible new feature - A way to generate assets (flags svg's) in a specific folder during angular compilation #1276

Open BruneXX opened 4 months ago

BruneXX commented 4 months ago

I'm reporting this related to the issue: https://github.com/lipis/flag-icons/issues/1265 starting from comment: https://github.com/lipis/flag-icons/issues/1265#issuecomment-2209366895

I'm using this library with Angular and I want to avoid (at compilation time) that angular build generates all the svg files in the root folder, do you know if there's any way to move all those *.svg files to a folder? in order to be used like:

/flags/*.svg files

My idea is to have this structure: ./project/assets/flags/*.svg ./project/project_file1.js ./project/project_file2.js ./project/project_fileN.js

it will be possible to add a way to set an absolute path for the flags svg files instead as an alternative to those relative paths? maybe a new lib feature to achieve that?

I think that will probably solve the problem that I've with the angular build setting all the flag images in the root folder of the build...

I'll appreciate to hear from you an this, thanks!

BruneXX commented 4 months ago

Another thing that it will be really great is if we could add just the flags needed instead of all the flags, but that's less important for me than the other feature.

moamenhredeen commented 4 months ago

is there any plans to add this feature

NotTsunami commented 1 month ago

Another thing that it will be really great is if we could add just the flags needed instead of all the flags, but that's less important for me than the other feature.

This is something I've been specifically looking into recently. You should be able to use PurgeCSS for this. I don't know if you can integrate PurgeCSS directly into your build process using the PostCSS plugin with Angular 18 and esbuild, but you can definitely do a postbuild step invoking PurgeCSS.

I'm reporting this related to the issue: #1265 starting from comment: #1265 (comment)

I'm using this library with Angular and I want to avoid (at compilation time) that angular build generates all the svg files in the root folder, do you know if there's any way to move all those *.svg files to a folder? in order to be used like:

/flags/*.svg files

My idea is to have this structure: ./project/assets/flags/*.svg ./project/project_file1.js ./project/project_file2.js ./project/project_fileN.js

it will be possible to add a way to set an absolute path for the flags svg files instead as an alternative to those relative paths? maybe a new lib feature to achieve that?

I think that will probably solve the problem that I've with the angular build setting all the flag images in the root folder of the build...

I'll appreciate to hear from you an this, thanks!

This I will do some due diligence on. I've only used React and Vue in the field, so I don't have experience with configuring Angular builds. It's been proposed that we change our folder structure, and I'm not entirely opposed to this, but I don't think that would directly affect the output structure.